netdev - Re: [PATCH] bonding:fix speed unknown,lacp bonding failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE3RKN=dy8t0W-pvq7yro643i-0AZziOw+7BQ5fc4z7JquC__Q@mail.gmail.com>
Date:	Fri, 5 Jul 2013 11:20:24 +0200
From:	Veaceslav Falico <darkmag@...il.com>
To:	Wangyufen <wangyufen@...wei.com>
Cc:	netdev <netdev@...r.kernel.org>, lizefan@...wei.com,
	zhangdianfang@...wei.com
Subject: Re: [PATCH] bonding:fix speed unknown,lacp bonding failed

On Fri, Jul 5, 2013 at 8:32 AM, Wangyufen <wangyufen@...wei.com> wrote:
> From: "Wang Yufen" <wangyufen@...wei.com>
>
> We bonded nic using LACP mode repeatedly, occasionally LACP bonding failed,
> because a slave nic port speed was unknown. But when we used ethtool to
> check the slave NIC status, the nic status was normal,speed was 10000Mb/s.

Can you give a bit more details on how did you test? And which nic was it?

I've tried to reproduce it with with while :; do echo +/- >
/sys/.../bonding/slaves; done
but failed.

>
> Bonding get the NIC speed from NIC drivers,just when enslave nic
> and receive NETDEV_CHANGE event.We call bond_update_speed_duplex to
> update speed and duplex when miimon inspect slave link is OK and slave
> speed is unknown.
>
>
> Signed-off-by: Wang Yufen <wangyufen@...wei.com>
> ---
>  drivers/net/bonding/bond_main.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index f975696..d288a98 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2301,8 +2301,11 @@ static int bond_miimon_inspect(struct bonding *bond)
>
>                 switch (slave->link) {
>                 case BOND_LINK_UP:
> -                       if (link_state)
> +                       if (link_state) {
> +                               if (slave->speed == SPEED_UNKNOWN)
> +                                       bond_update_speed_duplex(slave);
>                                 continue;
> +                       }
>
>                         slave->link = BOND_LINK_FAIL;
>                         slave->delay = bond->params.downdelay;
> --
> 1.8.0
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
Best regards,
Veaceslav Falico
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html