netdev - Re: [PATCH iproute2] ipbatch: fix use of 'ip netns exec'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1373057353.1913.55.camel@bwh-desktop.uk.level5networks.com>
Date:	Fri, 5 Jul 2013 21:49:13 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
CC:	<shemminger@...tta.com>, <netdev@...r.kernel.org>,
	<junwei.zhang@...nd.com>
Subject: Re: [PATCH iproute2] ipbatch: fix use of 'ip netns exec'

On Fri, 2013-07-05 at 18:05 +0200, Nicolas Dichtel wrote:
> From: JunweiZhang <junwei.zhang@...nd.com>
> 
> execvp() does not return when the command succeed, hence all commands in the
> batch file after the line 'ip netns exec' are not executed.
>
> Let's fork before calling execvp().

A Unix shell forks every command it runs, so why should ip do this too?

[...]
> +       return WIFEXITED(status) ? EXIT_SUCCESS : EXIT_FAILURE;
[...]

So you throw away the original exit code of the child process.

I suspect your actual problem has to do with the exit code of the child,
and your shell script contains 'set -e'.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html