lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 06 Jul 2013 18:10:03 -0700 (PDT) From: David Miller <davem@...emloft.net> To: wei.liu2@...rix.com Cc: JBeulich@...e.com, ian.campbell@...rix.com, g.w.kant@...enet.nl, xen-devel@...ts.xen.org, netdev@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH] xen-netfront: pull on receive skb may need to happen earlier From: Wei Liu <wei.liu2@...rix.com> Date: Fri, 5 Jul 2013 15:53:19 +0100 > You seem to be altering the behavior of the original code, because in > your patch the skb->len is incremented before use, while in the original > code (which calls skb_headlen in handle_incoming_packet) the skb->len is > correctly set. Indeed, I think you're right. Because __pskb_pull_tail() decrements the number of bytes pulled from skb->data_len, it won't be accounted for in skb->len -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists