netdev - Re: [PATCH iproute2] ipbatch: fix use of 'ip netns exec'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1373291839.3428.81.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 8 Jul 2013 14:57:19 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	<nicolas.dichtel@...nd.com>
CC:	<shemminger@...tta.com>, <netdev@...r.kernel.org>,
	<junwei.zhang@...nd.com>
Subject: Re: [PATCH iproute2] ipbatch: fix use of 'ip netns exec'

On Mon, 2013-07-08 at 11:41 +0200, Nicolas Dichtel wrote:
> Le 05/07/2013 22:49, Ben Hutchings a écrit :
> > On Fri, 2013-07-05 at 18:05 +0200, Nicolas Dichtel wrote:
> >> From: JunweiZhang <junwei.zhang@...nd.com>
> >>
> >> execvp() does not return when the command succeed, hence all commands in the
> >> batch file after the line 'ip netns exec' are not executed.
> >>
> >> Let's fork before calling execvp().
> >
> > A Unix shell forks every command it runs, so why should ip do this too?
> Just to show the problem:
> 
> $ cat test.batch
> netns add netns1
> netns exec netns1 ip l
> netns
> $ ip -b test.batch
[...]

Sorry, I totally missed that there is this 'batch' sub-command in ip.  I
think you are right that it should fork in this case.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html