netdev - Re: [PATCH] ip: set the close-on-exec flag for descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANaxB-wjwobCnYBsL2mpR9V=WR5w7_cCgR6Pp9OA72rtVsD27A@mail.gmail.com>
Date:	Mon, 8 Jul 2013 19:51:08 +0400
From:	Andrey Wagin <avagin@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ip: set the close-on-exec flag for descriptors

Hi Eric,

2013/7/8 Eric Dumazet <eric.dumazet@...il.com>:
>> Applied
>
> It seems it could break ip command for old kernels, as SOCK_CLOEXEC is
> supported from 2.6.27
>
> Not sure if its worth a patch, to do the normal socket() call followed
> by legacy fcntl() one.

fcntl is not safe for multithread applications. If libnetlink isn't
going to be used for them, I don't have objection. The patch is
attached.

Thanks.

Download attachment "0001-ip-avoid-using-SOCK_CLOEXEC-to-save-backward-compati.patch" of type "application/octet-stream" (1277 bytes)