netdev - RE: [PATCH] drivers/net: enic: release rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <644DFB2E795E0348A1614A34EE0D35711837FDB1@xmb-rcd-x05.cisco.com>
Date:	Mon, 8 Jul 2013 16:26:58 +0000
From:	"Neel Patel (neepatel)" <neepatel@...co.com>
To:	"Nishank Trivedi (nistrive)" <nistrive@...co.com>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Christian Benvenuti (benve)" <benve@...co.com>
Subject: RE: [PATCH] drivers/net: enic: release rtnl_lock on error-path

Looks good.

Thanks!

-----Original Message-----
From: Nishank Trivedi (nistrive) 
Sent: Monday, July 08, 2013 9:26 AM
To: Konstantin Khlebnikov
Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Neel Patel (neepatel); Christian Benvenuti (benve)
Subject: Re: [PATCH] drivers/net: enic: release rtnl_lock on error-path

On 7/8/13 12:22 AM, Konstantin Khlebnikov wrote:
> enic_change_mtu_work() must call rtnl_unlock() on all exiting paths.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> Cc: Christian Benvenuti <benve@...co.com>
> Cc: Roopa Prabhu <roprabhu@...co.com>
> Cc: Neel Patel <neepatel@...co.com>
> Cc: Nishank Trivedi <nistrive@...co.com>
> ---
>   drivers/net/ethernet/cisco/enic/enic_main.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> index 635f559..992ec2e 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> @@ -1761,6 +1761,7 @@ static void enic_change_mtu_work(struct work_struct *work)
>   	enic_synchronize_irqs(enic);
>   	err = vnic_rq_disable(&enic->rq[0]);
>   	if (err) {
> +		rtnl_unlock();
>   		netdev_err(netdev, "Unable to disable RQ.\n");
>   		return;
>   	}
> @@ -1773,6 +1774,7 @@ static void enic_change_mtu_work(struct work_struct *work)
>   	vnic_rq_fill(&enic->rq[0], enic_rq_alloc_buf);
>   	/* Need at least one buffer on ring to get going */
>   	if (vnic_rq_desc_used(&enic->rq[0]) == 0) {
> +		rtnl_unlock();
>   		netdev_err(netdev, "Unable to alloc receive buffers.\n");
>   		return;
>   	}
>

Acked.

Thanks.