netdev - Re: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51DC340F.2060402@atmel.com>
Date:	Tue, 9 Jul 2013 18:02:23 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Jongsung Kim <neidhard.kim@....com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear
 bit

On 09/07/2013 10:36, Jongsung Kim :
> Signed-off-by: Jongsung Kim <neidhard.kim@....com>

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
Cc: stable <stable@...r.kernel.org> # 3.10+

Thanks for having spotted that.

Best regards,

> ---
>   drivers/net/ethernet/cadence/macb.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index c89aa41..b4e0dc8 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
>   static void macb_configure_caps(struct macb *bp)
>   {
>   	if (macb_is_gem(bp)) {
> -		if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
> +		if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
>   			bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
>   	}
>   }
>


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html