netdev - Re: e1000e on thinkpad x60: interrupt problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130710113742.GA9113@amd.pavel.ucw.cz>
Date:	Wed, 10 Jul 2013 13:37:43 +0200
From:	Pavel Machek <pavel@....cz>
To:	Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
	"Rose, Gregory V" <gregory.v.rose@...el.com>,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Dave, Tushar N" <tushar.n.dave@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: e1000e on thinkpad x60: interrupt problem

Hi!

> > Yeah, of course you need to ask e1000e if it generated the
> > interrupt. That part works. The part that actually generates the
> > interrupt does not. Take a look at original mail...
> > 
> > packet comes
> > e1000e sets E1000_ICR_INT_ASSERTED bit
> > e1000e tries to generate an interrupt and fails
> > 50msec passes
> 
> ^^ thats the ASPM timeout length.
> 
> > AHCI generates interrupt
> > all the handlers are called
> >     AHCI processes its interrupt, handles disk read
> >     e1000_intr notices E1000_ICR_INT_ASSERTED bit, delivers the packet.
> > 
> > Network still works, only slowly. Ping goes lower when I use the
> > disk. That matches what I see.
> > 
> > Do you have other explanation?
> 
> Regardless of what others are saying I believe you have an issue with
> ASPM being enabled.  All the discussion about shared interrupts, is
> just a distraction.  This issue would still occur (and just be worse)
> without a shared interrupt.

Agreed.

> You already mentioned that a kernel hack to disable ASPM fixes it, but
> you can just boot with different options to turn off ASPM.
> 
> pcie_aspm=off

Are you sure? AFAICT linux will not turn off aspm if ACPI says
so.. hence the hack. 

# From: Robert Hancock <hancockrwd@...il.com>
# To: Pavel Machek <pavel@....cz>
# CC: Greg KH <greg@...ah.com>, kernel list
# <linux-kernel@...r.kernel.org>,
#         joe.lawrence@...atus.com, myron.stowe@...hat.com,
#         bhelgaas@...gle.com
# Subject: Re: /sys/module/pcie_aspm/parameters/policy not writable?
# ...
# > pavel@amd:~$ dmesg | grep -i aspm
# > ACPI FADT declares the system doesn't support PCIe ASPM, so disable
# it
# 
# IIRC, this message is somewhat misleading. When that FADT flag is set
# by the BIOS, the kernel doesn't so much disable ASPM as disable the
# kernel's control over ASPM. I believe this was to match Windows
# behavior.

It looks like ASPM needs to be off, but BIOS enables ASPM and tells
kernel it is not supported... and that means that kernel will not
disable it :-(.

I guess there's no way to do ASPM disable for single device from the
driver?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html