netdev - Re: [PATCH net v3] ipv6: fix route selection if kernel is not compiled with CONFIG_IPV6_ROUTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130711.115142.733130366565562474.davem@davemloft.net>
Date:	Thu, 11 Jul 2013 11:51:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, petrus.lt@...il.com,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net v3] ipv6: fix route selection if kernel is not
 compiled with CONFIG_IPV6_ROUTER_PREF

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 11 Jul 2013 12:43:42 +0200

> This is a follow-up patch to 3630d40067a21d4dfbadc6002bb469ce26ac5d52
> ("ipv6: rt6_check_neigh should successfully verify neigh if no NUD
> information are available").
> 
> Since the removal of rt->n in rt6_info we can end up with a dst ==
> NULL in rt6_check_neigh. In case the kernel is not compiled with
> CONFIG_IPV6_ROUTER_PREF we should also select a route with unkown
> NUD state but we must not avoid doing round robin selection on routes
> with the same target. So introduce and pass down a boolean ``do_rr'' to
> indicate when we should update rt->rr_ptr. As soon as no route is valid
> we do backtracking and do a lookup on a higher level in the fib trie.
> 
> v2:
> a) Improved rt6_check_neigh logic (no need to create neighbour there)
>    and documented return values.
> 
> v3:
> a) Introduce enum rt6_nud_state to get rid of the magic numbers
>    (thanks to David Miller).
> b) Update and shorten commit message a bit to actualy reflect
>    the source.
> 
> Reported-by: Pierre Emeriaud <petrus.lt@...il.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html