netdev - Re: skb_warn_bad_offload related to IPv6 in 3.9.9+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51DF2CCE.9050103@candelatech.com>
Date:	Thu, 11 Jul 2013 15:08:14 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: skb_warn_bad_offload related to IPv6 in 3.9.9+

On 07/11/2013 02:37 PM, Ben Hutchings wrote:
> On Thu, 2013-07-11 at 11:52 -0700, Ben Greear wrote:
>> This kernel has local patches applied...but I don't think it has anything
>> that would cause this....
>>
>> The wanlink module is something we added.  It is now GPL, but code is
>> not upstream.  I don't think it's in directly related to the splat though...
>>
>> Only saw one splat, and system remains stable as far as we can tell.
>>
>> ------------[ cut here ]------------
>> WARNING: at /home/greearb/git/linux-3.9.dev.y/net/core/dev.c:2179 skb_warn_bad_offload+0xc2/0xcb()
>> Hardware name: X7DBU
>> e1000e: caps=(0x00000000700003a9, 0x0000000000000000) len=2942 data_len=1428 gso_size=1428 gso_type=16 ip_summed=1
> [...]
>
> The skb requires TSO, which requires that ip_summed = CHECKSUM_PARTIAL.
> But ip_summed = CHECKSUM_UNNECESSARY.
>
> To me, this suggests that the receiving device i.e. wanlink has some
> kind of broken LRO that can't be turned off...

The wanlink module is a set of 2-port bridges with network emulation
feature set.

I am not certain the IPv6 traffic in this splat traversed it at all, but
I guess it is possible.  We automatically disable LRO on ports used
by the wanlink bridge, by the way.

I think the wanlink stuff only shows up in the trace because
it was interrupted by IRQ and then the soft-irq packet rx
path caused the splat.  I could easily be mistaken, however.

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html