netdev - Re: [RFC PATCH] net: add a rate_limit attribute to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130711.163501.353724739279106871.davem@davemloft.net>
Date:	Thu, 11 Jul 2013 16:35:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	john.fastabend@...il.com
Cc:	stephen@...workplumber.org, ben@...adent.org.uk,
	jesse.brandeburg@...el.com, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com, therbert@...gle.com
Subject: Re: [RFC PATCH] net: add a rate_limit attribute to netdev_queue
 and a rtnetlink

From: John Fastabend <john.fastabend@...il.com>
Date: Wed, 10 Jul 2013 07:04:12 -0700

> /* Queue Attributes management
>  *      Nested layout of queue attributes is:
>  *      [IFLA_QUEUE_ATTRIBS]
>  *              [IFLA_QUEUE_ATTRIB]
>  *                      [IFLA_QUEUE_INDEX]      <required>
>  *                      [IFLA_QUEUE_RATE]       <optional>
>  *              [IFLA_QUEUE_ATTRIB]
>  *                      [...]
>  */

Since these are specifically TX queue attributes, and not
RX queue attributes, please add "_TX_" in the names both
of the attributes themselves and the ->ndo_*() method.

> +static const struct nla_policy ifla_queue_policy[IFLA_QUEUE_MAX+1] = {
> +	[IFLA_QUEUE_INDEX]	= { .type = NLA_U32},
> +	[IFLA_QUEUE_RATE]	= { .type = NLA_U32},
> +};

Space needed after NLA_U32 and the closing brace.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html