netdev - Re: [PATCH net v2] gso: Update tunnel segmentation to support Tx checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1373510223.4600.36.camel@edumazet-glaptop>
Date:	Wed, 10 Jul 2013 19:37:03 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	Dmitry Kravkov <dmitry@...adcom.com>, netdev@...r.kernel.org,
	stephen@...workplumber.org, pshelar@...ira.com,
	joseph.gasparakis@...el.com, jesse@...ira.com,
	Eilon Greenstein <eilong@...adcom.com>
Subject: Re: [PATCH net v2] gso: Update tunnel segmentation to support Tx
 checksum offload

On Wed, 2013-07-10 at 19:30 -0700, Alexander Duyck wrote:

> 
> It was my understanding that the code for enabling TSO for encapsulated
> frames was good as Joseph has been working on it and testing it for
> i40e.  I'm assuming if you turn off TSO then the GSO and Tx checksum are
> working correctly?  I just want to make sure the issue you are seeing
> isn't in any way related to my patch.

Disabling TSO is solving the issue, and your patch solves the csum
performance issue.

I would like to fully understand the problems before acknowledging your
patch, if you do not mind ;)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html