netdev - Re: [RFC PATCH net-next] net ipv6: Remove rebundant rt6i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51DE5F79.7080202@6wind.com>
Date:	Thu, 11 Jul 2013 09:32:09 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Fan Du <fan.du@...driver.com>
CC:	yoshfuji@...ux-ipv6.org, jmorris@...ei.org, kuznet@....inr.ac.ru,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings
 initialization

Le 11/07/2013 02:27, Fan Du a écrit :
> Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
> has zeroed the rest of rt excluding the first dst memember.
>
> Signed-off-by: Fan Du <fan.du@...driver.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

> ---
>   net/ipv6/route.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 7ca87b3..b88f99f 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -278,7 +278,6 @@ static inline struct rt6_info *ip6_dst_alloc(struct net *net,
>   		rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
>   		rt->rt6i_genid = rt_genid(net);
>   		INIT_LIST_HEAD(&rt->rt6i_siblings);
> -		rt->rt6i_nsiblings = 0;
>   	}
>   	return rt;
>   }
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html