netdev - Re: [PATCH net v2] gso: Update tunnel segmentation to support Tx checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1373503334.4600.27.camel@edumazet-glaptop>
Date:	Wed, 10 Jul 2013 17:42:14 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	pshelar@...ira.com, joseph.gasparakis@...el.com, jesse@...ira.com
Subject: Re: [PATCH net v2] gso: Update tunnel segmentation to support Tx
 checksum offload

On Wed, 2013-07-10 at 17:05 -0700, Alexander Duyck wrote:
> This change makes it so that the GRE and VXLAN tunnels can make use of Tx
> checksum offload support provided by some drivers via the hw_enc_features.
> Without this fix enabling GSO means sacrificing Tx checksum offload and
> this actually leads to a performance regression as shown below:
> 
>             Utilization
>             Send
> Throughput  local         GSO
> 10^6bits/s  % S           state
>   6276.51   8.39          enabled
>   7123.52   8.42          disabled

While testing your patch, I discovered TSO support is completely broken
on GRE, using bnx2x testbed.

Oh well.

It seems Nicira guys do not test a lot their patches.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html