netdev - Re: [net PATCH] atl1e: fix dma mapping warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130714022235.GA3429@neilslaptop.think-freely.org>
Date:	Sat, 13 Jul 2013 22:22:36 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...hat.com>
Cc:	netdev@...r.kernel.org, jcliburn@...il.com, chris.snook@...il.com
Subject: Re: [net PATCH] atl1e: fix dma mapping warnings

On Fri, Jul 12, 2013 at 04:26:52PM -0700, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Fri, 12 Jul 2013 10:58:48 -0400
> 
> > Recently had this backtrace reported:
>  ...
> > The usual straighforward failure to check for dma_mapping_error after a map
> > operation is completed.
> > 
> > This patch should fix it, the reporter wandered off after filing this bz:
> > https://bugzilla.redhat.com/show_bug.cgi?id=954170
> > 
> > and I don't have hardware to test, but the fix is pretty straightforward, so I
> > figured I'd post it for review.
> > 
> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> 
> Applied with one style fix:
> 
> > -static void atl1e_tx_map(struct atl1e_adapter *adapter,
> > +static int atl1e_tx_map(struct atl1e_adapter *adapter,
> >  		      struct sk_buff *skb, struct atl1e_tpd_desc *tpd)
> 
> I properly reindented the second line of the argument list.
> 
Understood, thank you David.
Neil

> Thanks.
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html