netdev - Re: [PATCH] ethtool: fixed trailing statements in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1373896458.3745.7.camel@bwh-desktop.uk.level5networks.com>
Date:	Mon, 15 Jul 2013 14:54:18 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Dragos Foianu <dragos.foianu@...il.com>
CC:	<davem@...emloft.net>, <ben@...adent.org.uk>, <pshelar@...ira.com>,
	<mschmidt@...hat.com>, <ebiederm@...ssion.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ethtool: fixed trailing statements in ethtool

On Sat, 2013-07-13 at 14:43 +0100, Dragos Foianu wrote:
> Applied fixes suggested by checkpatch.pl.
> 
> Signed-off-by: Dragos Foianu <dragos.foianu@...il.com>

I think that it's fine to put the conditional statement on the same line
for repetitive conversion code like this.  I don't think anyone's likely
to mis-read it, which I think is the reason why checkpatch warns.

But I also won't object to this.  I don't mind either way.

Ben.

> ---
>  net/core/ethtool.c |   30 ++++++++++++++++++++----------
>  1 file changed, 20 insertions(+), 10 deletions(-)
> 
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index ab5fa63..78e9d92 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -279,11 +279,16 @@ static u32 __ethtool_get_flags(struct net_device *dev)
>  {
>  	u32 flags = 0;
>  
> -	if (dev->features & NETIF_F_LRO)	     flags |= ETH_FLAG_LRO;
> -	if (dev->features & NETIF_F_HW_VLAN_CTAG_RX) flags |= ETH_FLAG_RXVLAN;
> -	if (dev->features & NETIF_F_HW_VLAN_CTAG_TX) flags |= ETH_FLAG_TXVLAN;
> -	if (dev->features & NETIF_F_NTUPLE)	     flags |= ETH_FLAG_NTUPLE;
> -	if (dev->features & NETIF_F_RXHASH)	     flags |= ETH_FLAG_RXHASH;
> +	if (dev->features & NETIF_F_LRO)
> +		flags |= ETH_FLAG_LRO;
> +	if (dev->features & NETIF_F_HW_VLAN_CTAG_RX)
> +		flags |= ETH_FLAG_RXVLAN;
> +	if (dev->features & NETIF_F_HW_VLAN_CTAG_TX)
> +		flags |= ETH_FLAG_TXVLAN;
> +	if (dev->features & NETIF_F_NTUPLE)
> +		flags |= ETH_FLAG_NTUPLE;
> +	if (dev->features & NETIF_F_RXHASH)
> +		flags |= ETH_FLAG_RXHASH;
>  
>  	return flags;
>  }
> @@ -295,11 +300,16 @@ static int __ethtool_set_flags(struct net_device *dev, u32 data)
>  	if (data & ~ETH_ALL_FLAGS)
>  		return -EINVAL;
>  
> -	if (data & ETH_FLAG_LRO)	features |= NETIF_F_LRO;
> -	if (data & ETH_FLAG_RXVLAN)	features |= NETIF_F_HW_VLAN_CTAG_RX;
> -	if (data & ETH_FLAG_TXVLAN)	features |= NETIF_F_HW_VLAN_CTAG_TX;
> -	if (data & ETH_FLAG_NTUPLE)	features |= NETIF_F_NTUPLE;
> -	if (data & ETH_FLAG_RXHASH)	features |= NETIF_F_RXHASH;
> +	if (data & ETH_FLAG_LRO)
> +		features |= NETIF_F_LRO;
> +	if (data & ETH_FLAG_RXVLAN)
> +		features |= NETIF_F_HW_VLAN_CTAG_RX;
> +	if (data & ETH_FLAG_TXVLAN)
> +		features |= NETIF_F_HW_VLAN_CTAG_TX;
> +	if (data & ETH_FLAG_NTUPLE)
> +		features |= NETIF_F_NTUPLE;
> +	if (data & ETH_FLAG_RXHASH)
> +		features |= NETIF_F_RXHASH;
>  
>  	/* allow changing only bits set in hw_features */
>  	changed = (features ^ dev->features) & ETH_ALL_FEATURES;

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html