netdev - Re: [PATCH] net: convert mvneta to build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130715173523.4505e8c4@skate>
Date:	Mon, 15 Jul 2013 17:35:23 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Willy Tarreau <w@....eu>
Cc:	netdev@...r.kernel.org,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH] net: convert mvneta to build_skb()

Dear Willy Tarreau,

On Mon, 15 Jul 2013 17:30:49 +0200, Willy Tarreau wrote:

> On Mon, Jul 15, 2013 at 05:23:21PM +0200, Thomas Petazzoni wrote:
> > The big-endian support is pretty light in terms of driver changes, so
> > if there are conflicts, they should be easy to solve.
> 
> I agree.
> 
> BTW, I'm still having the patch to re-enable phy-polling at boot in my
> queue. Last time I tried without it I still only had eth0 working. I
> completely forgot about this one. Since I did it blindly, I have no way
> to verify if what I've done is necessary according to the specs. But I'm
> quite sure that the NICs that are not enabled by the boot loaders don't
> work.
> 
> If you want, I'll resend it to you at the same time.

I still believe this is not the right fix, but unfortunately, I haven't
had the time to work on what would be the right fix. Hardware PHY
polling has been intentionally disabled, and the driver should work
without, since the PHY polling is done in software by the phylib.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html