netdev - Re: [PATCH] net: convert mvneta to build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130715170100.GB10157@1wt.eu>
Date:	Mon, 15 Jul 2013 19:01:00 +0200
From:	Willy Tarreau <w@....eu>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	netdev <netdev@...r.kernel.org>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH] net: convert mvneta to build_skb()

Hi Florian,

On Mon, Jul 15, 2013 at 04:52:44PM +0100, Florian Fainelli wrote:
> > I still believe this is not the right fix, but unfortunately, I haven't
> > had the time to work on what would be the right fix. Hardware PHY
> > polling has been intentionally disabled, and the driver should work
> > without, since the PHY polling is done in software by the phylib.
> 
> You may now be able to use the PHY interrupt bit from your MAC
> interrupt handler and call phy_mac_interrupt() provided by libphy. I
> added it specifically to be able to use PHY link interrupts connected
> to the MAC.

Thanks for the tip. I'm not seeing any interrupt when I plug/unplug a
cable, so maybe we first need to set a specific bit in the interrupt
mask to enable interrupt delivery on link state change prior to this.

Regards,
Willy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html