netdev - Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high packet delay/jitter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1373911942.2062.24.camel@joe-AO722>
Date:	Mon, 15 Jul 2013 11:12:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Paolo Valente <paolo.valente@...more.it>
Cc:	Jamal Hadi Salim <jhs@...atatu.com>,
	"David S. Miller" <davem@...emloft.net>, shemminger@...tta.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	fchecconi@...il.com, rizzo@....unipi.it
Subject: Re: [PATCH BUGFIX] pkt_sched: sch_qfq: remove a source of high
 packet delay/jitter

On Mon, 2013-07-15 at 20:01 +0200, Paolo Valente wrote:
> QFQ+ inherits from QFQ a design choice that may cause a high packet
> delay/jitter and a severe short-term unfairness.
[]
> diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
[]
> @@ -189,6 +188,7 @@ struct qfq_sched {
>  	struct qfq_aggregate	*in_serv_agg;   /* Aggregate being served. */
>  	u32			num_active_agg; /* Num. of active aggregates */
>  	u32			wsum;		/* weight sum */
> +	unsigned long		iwsum;		/* inverse weight sum*/

This is a different size for 32/64 bit compiles
and may be better as u32.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html