netdev - Re: [PATCH] net: convert mvneta to build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Jul 2013 00:02:30 +0100
From:	Florian Fainelli <florian@...nwrt.org>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:	Willy Tarreau <w@....eu>, netdev <netdev@...r.kernel.org>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH] net: convert mvneta to build_skb()

Hello Thomas,

2013/7/15 Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>:
> Dear Florian Fainelli,
>
> On Mon, 15 Jul 2013 16:52:44 +0100, Florian Fainelli wrote:
>
>> > I still believe this is not the right fix, but unfortunately, I haven't
>> > had the time to work on what would be the right fix. Hardware PHY
>> > polling has been intentionally disabled, and the driver should work
>> > without, since the PHY polling is done in software by the phylib.
>>
>> You may now be able to use the PHY interrupt bit from your MAC
>> interrupt handler and call phy_mac_interrupt() provided by libphy. I
>> added it specifically to be able to use PHY link interrupts connected
>> to the MAC.
>
> Right, but the MAC feature in question makes the MAC directly talks to
> the PHY to configure it, completely bypassing the entire libphy logic.
> I am not sure how to handle this together with libphy.

Then you might just replace the default libphy with your PHY state
machine and manage it from within the mvneta driver. This is something
less usual but libphy still allows that.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html