netdev - Re: [patch net-next RFC 1/3] net: add ndo to get id of physical port of the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130716064109.GA1600@minipsycho.orion>
Date:	Tue, 16 Jul 2013 08:41:09 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, Narendra_K@...l.com,
	john.r.fastabend@...el.com
Subject: Re: [patch net-next RFC 1/3] net: add ndo to get id of physical port
 of the device

Tue, Jul 16, 2013 at 12:01:57AM CEST, bhutchings@...arflare.com wrote:
>On Mon, 2013-07-15 at 19:07 +0200, Jiri Pirko wrote:
>> This patch adds a ndo for getting physical port of the device. Driver
>> which is aware of being virtual function of some physical port should
>> implement this ndo.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>> ---
>>  include/linux/netdevice.h | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>> 
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 0741a1e..e85f177 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -728,6 +728,16 @@ struct netdev_fcoe_hbainfo {
>>  };
>>  #endif
>>  
>> +#define MAX_PHYS_PORT_ID_LEN 32
>> +
>> +/* This structure holds a universally unique identifier to
>> + * identify the physical port used by a netdevice
>[...]
>
>There is a slight problem with saying 'universally unique identifier'
>which is that it may be taken to mean specifically a DCE 128-bit UUID.
>Is there a slightly more generic term that would clearly allow for other
>ID spaces here?  Or should we give a list of examples: 'such as a
>128-bit UUID, globally unique MAC-48 or EUI-64'?

Well I do not have any speficic format in mind. I think that whatever
hash (driver's choice) would do. I will reword the comment.

Thanks Ben.

Jiri

>
>Ben.
>
>-- 
>Ben Hutchings, Staff Engineer, Solarflare
>Not speaking for my employer; that's the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html