netdev - Re: [PATCH net 2/6] bnx2x: prevent statistics update flow to act before statistics are started

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51E58D8A.80206@cogentembedded.com>
Date:	Tue, 16 Jul 2013 22:14:34 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Dmitry Kravkov <dmitry@...adcom.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/6] bnx2x: prevent statistics update flow to act
 before statistics are started

Hello.

On 07/16/2013 07:21 PM, Dmitry Kravkov wrote:

> This in order to serialize statistics requests sent to FW,
> otherwise two outstanding queries may cause FW assert.

> Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> Signed-off-by: Ariel Elior <ariele@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> ---
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x.h       | 1 +
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c  | 1 +
>   drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c | 6 +++++-
>   3 files changed, 7 insertions(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
> index dedbd76..bdbd87e 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
> @@ -1830,6 +1830,7 @@ struct bnx2x {
>
>   	int fp_array_size;
>   	u32 dump_preset_idx;
> +	atomic_t				stats_started;

    Why it's so wildly indented if its neighbors are not?

>   };
>
>   /* Tx queues may be less or equal to Rx queues */

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html