netdev - Re: [net PATCH] atl1e: unmap partially mapped skb on dma error and free skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130716204849.GE8940@hmsreliant.think-freely.org>
Date:	Tue, 16 Jul 2013 16:48:49 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	jcliburn@...il.com, chris.snook@...il.com
Subject: Re: [net PATCH] atl1e: unmap partially mapped skb on dma error and
 free skb

On Tue, Jul 16, 2013 at 12:11:25PM -0700, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Tue, 16 Jul 2013 10:49:41 -0400
> 
> > Ben Hutchings pointed out that my recent update to atl1e:
> > 
> > commit 352900b583b2852152a1e05ea0e8b579292e731e
> > Author: Neil Horman <nhorman@...driver.com>
> > Date:   Fri Jul 12 10:58:48 2013 -0400
> > 
> >     atl1e: fix dma mapping warnings
> > 
> > Was missing a bit of code.  Specifically it reset the hardware tx ring to its
> > origional state when we hit a dma error, but didn't unmap any exiting mappings
> > from the operation.  This patch fixes that up.  It also remembers to free the
> > skb in the event that an error occurs, so we don't leak.  Untested, as I don't
> > have hardware.  I think its pretty straightforward, but please review closely.
> > 
> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> 
> Applied, but please refer to commits in the form "$SHA1ID ("Commit message
> header line")", I fixed it up for you this time.
> 
copy, thanks dave
Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html