netdev - Re: sysfs_format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374017532.1949.57.camel@joe-AO722>
Date:	Tue, 16 Jul 2013 16:32:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: sysfs_format_mac

On Tue, 2013-07-16 at 16:25 -0700, David Miller wrote:
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
[]
>  ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len)
[]
> -       l = _format_mac_addr(buf, PAGE_SIZE, addr, len);
> -       l += scnprintf(buf + l, PAGE_SIZE - l, "\n");
[]
> +       return scnprintf(buf, PAGE_SIZE, "%*phC", len, addr);

missing newline?

	scnprintf(buf, PAGE_ SIZE, "%*phC\n", len, addr);



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html