netdev - RE: [PATCH net] hyperv: Fix the NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8906250c5dfc4f7ab0d84019bf7b9a44@SN2PR03MB061.namprd03.prod.outlook.com>
Date:	Wed, 17 Jul 2013 11:40:41 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Haiyang Zhang <haiyangz@...rosoft.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Haiyang Zhang <haiyangz@...rosoft.com>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
Subject: RE: [PATCH net] hyperv: Fix the NETIF_F_SG flag setting in netvsc



> -----Original Message-----
> From: Haiyang Zhang [mailto:haiyangz@...rosoft.com]
> Sent: Wednesday, July 17, 2013 2:01 AM
> To: davem@...emloft.net; netdev@...r.kernel.org
> Cc: Haiyang Zhang; KY Srinivasan; olaf@...fle.de; jasowang@...hat.com; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org
> Subject: [PATCH net] hyperv: Fix the NETIF_F_SG flag setting in netvsc
> 
> SG mode is not currently supported by netvsc, so remove this flag for now.
> Otherwise, it will be unconditionally enabled by commit ec5f0615642
>     "Kill link between CSUM and SG features"
> Previously, the SG feature is disabled because CSUM is not set here.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>

We would need to apply this patch to 3.9 and 3.10 as well that are currently broken.

K. Y
> ---
>  drivers/net/hyperv/netvsc_drv.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 4dccead..23a0fff 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -431,8 +431,8 @@ static int netvsc_probe(struct hv_device *dev,
>  	net->netdev_ops = &device_ops;
> 
>  	/* TODO: Add GSO and Checksum offload */
> -	net->hw_features = NETIF_F_SG;
> -	net->features = NETIF_F_SG | NETIF_F_HW_VLAN_CTAG_TX;
> +	net->hw_features = 0;
> +	net->features = NETIF_F_HW_VLAN_CTAG_TX;
> 
>  	SET_ETHTOOL_OPS(net, &ethtool_ops);
>  	SET_NETDEV_DEV(net, &dev->device);
> --
> 1.7.4.1
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html