netdev - Re: [PATCH net v2 5/6] bnx2x: fix PTE write access error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51E711E9.7030500@cogentembedded.com>
Date:	Thu, 18 Jul 2013 01:51:37 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Dmitry Kravkov <dmitry@...adcom.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2 5/6] bnx2x: fix PTE write access error

Hello.

On 07/18/2013 01:45 AM, Dmitry Kravkov wrote:

> From: Barak Witkowsky <barak@...adcom.com>

> PTE write access error  might occur in MF_ALLOWED mode when IOMMU
> is active. The patch adds rmmod HSI indicating to MFW to stop
> running queries which might trigger this failure.

> Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> Signed-off-by: Ariel Elior <ariele@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

    Not signed off by the author?

> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> index 0f3de02..9394b7d 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

> @@ -12824,6 +12828,11 @@ static void __bnx2x_remove(struct pci_dev *pdev,
>   	bnx2x_dcbnl_update_applist(bp, true);
>   #endif
>
> +	if ((IS_PF(bp)) &&

    () not needed.

> +	    (!BP_NOMCP(bp)) &&

    Likewise.

> +	    (bp->flags & BC_SUPPORTS_RMMOD_CMD))
> +		bnx2x_fw_command(bp, DRV_MSG_CODE_RMMOD, 0);
> +

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html