netdev - Re: [patch net-next RFC 3/3] net: export physical port id via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Jul 2013 23:27:34 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	<Narendra_K@...l.com>
CC:	<jiri@...nulli.us>, <netdev@...r.kernel.org>,
	<john.r.fastabend@...el.com>
Subject: Re: [patch net-next RFC 3/3] net: export physical port id via sysfs

On Thu, 2013-07-18 at 01:09 +0530, Narendra_K@...l.com wrote:
> > -----Original Message-----
> > From: Jiri Pirko [mailto:jiri@...nulli.us]
[...]
> > Although this can be done by extending netdevice structure by another item,
> > I believe it is cleaner to do it by ndo. Driver has a flexibility to either compute
> > the phys port on fly of compute it once, store it in it's private data and use it
> > when ndo is called.

Doesn't the same argument apply to perm_addr?  And the flexibility there
turned out to be completely pointless.

> It seems to me that phys_port identifier is a net_device property,
> similar to netdev->dev_addr or netdev->if_port, and could be part of
> struct net_device  as discussed in [1].  My understanding may not be
> correct.
> 
> Hello Ben,  for the hybrid guest networking scenario, would it be
> required/helpful for phys_port to be part of net_device structure or
> either of the approaches would be fine.

I don't think it matters.  Either would be fine.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html