netdev - Re: [PATCH net 2/2] vxlan: fix igmp races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130718.131548.217898509443978446.davem@davemloft.net>
Date:	Thu, 18 Jul 2013 13:15:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	pshelar@...ira.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] vxlan: fix igmp races

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 18 Jul 2013 08:40:15 -0700

> There are two race conditions in existing code for doing IGMP
> management in workqueue in vxlan. First, the vxlan_group_used
> function checks the list of vxlan's without any protection, and
> it is possible for open followed by close to occur before the
> igmp work queue runs.
> 
> To solve these move the check into vxlan_open/stop so it is
> protected by RTNL. And split into two work structures so that
> there is no racy reference to underlying device state.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Applied, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html