netdev - Re: r8169: is the work queue is initialized at wrong place?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130718.201604.1029725996842278443.davem@davemloft.net>
Date:	Thu, 18 Jul 2013 20:16:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lekensteyn@...il.com
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: r8169: is the work queue is initialized at wrong place?

From: Peter Wu <lekensteyn@...il.com>
Date: Fri, 19 Jul 2013 00:41:57 +0200

> On Thursday 18 July 2013 23:53:43 Francois Romieu wrote:
>> Peter Wu <lekensteyn@...il.com> :
>> [...]
>> 
>> > However, this queue is only initialized in rtl_open:
>> > 
>> > 6673         INIT_WORK(&tp->wk.work, rtl_task);
>> > 6674
>> > 6675         smp_mb();
>> > 
>> > Shouldn't this INIT_WORK be done in rtl_init_one ?
>> 
>> (or cancel_work_sync in rtl8169_close to reduce the scope)
> Will this also work with multiple adapters? I currently have an on-board chip 
> using the r8169 driver and a separate PCI card.

Francois's suggested fix will work just as equally, regardless of
number of adapters.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html