netdev - RE: [RFC] qlcnic: Enhance ethtool to display board temperature.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ADFE82A996F10145934E45547759F763311A265D@avmb3.qlogic.org>
Date:	Fri, 19 Jul 2013 18:00:10 +0000
From:	Himanshu Madhani <himanshu.madhani@...gic.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: RE: [RFC] qlcnic: Enhance ethtool to display board temperature.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> Sent: Friday, July 19, 2013 9:11 AM
> To: Himanshu Madhani
> Cc: netdev; David Miller; Dept-NX Linux NIC Driver
> Subject: Re: [RFC] qlcnic: Enhance ethtool to display board temperature.
> 
> 
> >  static int
> > diff --git a/include/uapi/linux/ethtool.h
> > b/include/uapi/linux/ethtool.h index 38dbafa..2012015 100644
> > --- a/include/uapi/linux/ethtool.h
> > +++ b/include/uapi/linux/ethtool.h
> > @@ -101,6 +101,7 @@ struct ethtool_drvinfo {
> >  	__u32	testinfo_len;
> >  	__u32	eedump_len;	/* Size of data from ETHTOOL_GEEPROM
> (bytes) */
> >  	__u32	regdump_len;	/* Size of data from ETHTOOL_GREGS (bytes)
> */
> > +	__u32	board_temp;     /* board temperature */
> >  };
> 
> The idea is good but a couple of comments.
> 1. you can't break userspace ABI for ethtool by adding elements.
> 
> 2. There already exists a hardware monitoring subsystem in
>    Linux and there are applications that use it (like SNMP. If you want this
> feature to
>    be more than a developer toy, then it should use the existing subsystem
> API's.

Thanks for the comment. I will use ethtool -S ethX option to display board
Temperature. 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html