lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Jul 2013 13:30:07 +0530 From: Mugunthan V N <mugunthanvnm@...com> To: David Miller <davem@...emloft.net> CC: <netdev@...r.kernel.org>, <linux-omap@...r.kernel.org> Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs On 7/20/2013 6:02 AM, David Miller wrote: > From: Mugunthan V N <mugunthanvnm@...com> > Date: Fri, 19 Jul 2013 19:37:21 +0530 > >> Add support to show CPSW hardware statistics to user via ethtool get_regs >> ops so user can find if there were any error reported or the system is >> over loaded duing hagh data rate transfer. >> >> Signed-off-by: Mugunthan V N <mugunthanvnm@...com> > This is not the correct way to provide this functionality. ->get_regs() > is for dumping the raw hardware registers to userspace for low level > debugging purposes, not for providing HW specific statistics. > > The correct thing to do is provide an appropriate implementation of > the ->get_strings() and ->get_ethtool_stats() methods. Will change the implementation and resubmit the patch. Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists