netdev - Re: [PATCH] ath: wil6210: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bo5vyhrt.fsf@purkki.adurom.net>
Date:	Sun, 21 Jul 2013 19:55:34 +0300
From:	Kalle Valo <kvalo@...rom.com>
To:	Vladimir Kondratiev <qca_vkondrat@....qualcomm.com>
Cc:	<thomas@...llstrom.ca>, Larry Finger <Larry.Finger@...inger.net>,
	<linville@...driver.com>, <linux-wireless@...r.kernel.org>,
	<netdev@...r.kernel.org>, <wil6210@....qualcomm.com>
Subject: Re: [PATCH] ath: wil6210: Fix build error

(Dropping stable)

Vladimir Kondratiev <qca_vkondrat@....qualcomm.com> writes:

>> It also looked like that that driver or section of the kernel was compiling 
>> with -Werror. I haven't verrified that but I remember seeing "treating all 
>> warnings as errors" at one point.
>> 
> You are right, I have this in Makefile:
> (if one turn on extra warnings with -W, there will be lots of false alarms,
> that's why this ifeq())
>
> ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
> 	subdir-ccflags-y += -Werror
> endif

This is exactly why it's recommended not to use -Werror on releases.
It's ok when developers use it, but for end users -Werror should not be
enabled by default.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html