netdev - Re: [PATCH net-next] ip: initialize hash list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130722075245.70310bfa@nehalam.linuxnetplumber.net>
Date:	Mon, 22 Jul 2013 07:52:45 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Pravin B Shelar <pshelar@...ira.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ip: initialize hash list

On Sat, 20 Jul 2013 10:46:20 -0700
Joe Perches <joe@...ches.com> wrote:

> On Sat, 2013-07-20 at 10:26 -0700, Stephen Hemminger wrote:
> > Rather than relying on the assumption that zero means empty on
> > hash list head, the code should use the initialization macro.
> > Same effect, but follows API and avoids future breakage if hlist
> > implementation changes.
> []
> > --- a/net/ipv4/ip_tunnel.c	2013-07-19 09:12:37.213529343 -0700
> []
> > -	itn->tunnels = kzalloc(IP_TNL_HASH_SIZE * sizeof(struct hlist_head), GFP_KERNEL);
> > +	itn->tunnels = kmalloc(IP_TNL_HASH_SIZE * sizeof(struct hlist_head),
> > +			       GFP_KERNEL);
> >  	if (!itn->tunnels)
> >  		return -ENOMEM;
> > +
> > +	for (i = 0; i < IP_TNL_HASH_SIZE; i++)
> > +		INIT_HLIST_HEAD(&itn->tunnels[i]);
> 
> Hey Stephen.
> 
> Are you doing to do just this one or submit a series?

Hadn't planned on fixing more than one. And would not go outside code
that I actually use.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html