[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZOPZLz9HBuOXj0hsrMOvQAVR=koL72-4GQUxY4G+tN-VKgSA@mail.gmail.com>
Date: Mon, 22 Jul 2013 18:48:43 +0300
From: Or Gerlitz <or.gerlitz@...il.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Narendra_K@...l.com, bhutchings@...arflare.com,
netdev@...r.kernel.org, john.r.fastabend@...el.com
Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct
net_device and export it to sysfs
On Mon, Jul 22, 2013 at 2:49 PM, Jiri Pirko <jiri@...nulli.us> wrote:
> Mon, Jul 22, 2013 at 01:46:01PM CEST, Narendra_K@...l.com wrote:
>>Would it be useful to embed the port number at a known offset to ensure
>>uniformity across all drivers, if a driver choses to embed port number
>>as part of phys_port_id ?
> I would not do that. Just let it be meaningless number. That is best for
> security reasons as well.
What's wrong with uniformity on port number or even on the overall concept?
Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists