netdev - Re: [PATCH v3 net-next 2/2] tcp: TCP_NOTSENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374598098.3449.39.camel@edumazet-glaptop>
Date:	Tue, 23 Jul 2013 09:48:18 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Rick Jones <rick.jones2@...com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [PATCH v3 net-next 2/2] tcp: TCP_NOTSENT_LOWAT socket option

On Tue, 2013-07-23 at 09:20 -0700, Rick Jones wrote:

> Right - I am questioning whether it is worth the CPU increase.

There is no cpu increase for common workloads, and hosts can save GB of
precious memory thanks to this patch.

There is a cpu increase only for 'netperf' kind of program, relying on
blocking sendmsg() and using one thread per socket, _if_ and only _if_
they set a crazy notsent_lowat value.

Remember I forced nobody to do that. Its like forcing SO_SNDBUF with one
byte, and SO_RCVBUF with one byte, and expecting good line rate
performance !

This patch changes the threshold to get the 'socket is writeable'
POLLOUT event, and avoid filling socket write queues with too many
packets.

Like all thresholds, it has to be properly used.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html