netdev - Re: [PATCH] net: fix comment above build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcZ6=591=sY6kVVrwy4BHN_0LoMZ=u2yz88QyBUvtSOydA@mail.gmail.com>
Date:	Tue, 23 Jul 2013 19:04:06 +0100
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: fix comment above build_skb()

2013/7/23 Eric Dumazet <eric.dumazet@...il.com>:
> On Tue, 2013-07-23 at 16:39 +0100, Florian Fainelli wrote:
>> build_skb() specifies that the data parameter must come from a kmalloc'd
>> area, this is only true if frag_size equals 0, because then build_skb()
>> will use kzsize(data) to figure out the actual data size. Update the
>> comment to reflect that special condition.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>>  net/core/skbuff.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
>> index 20e02d2..d3174db 100644
>> --- a/net/core/skbuff.c
>> +++ b/net/core/skbuff.c
>> @@ -309,7 +309,8 @@ EXPORT_SYMBOL(__alloc_skb);
>>   * @frag_size: size of fragment, or 0 if head was kmalloced
>>   *
>>   * Allocate a new &sk_buff. Caller provides space holding head and
>> - * skb_shared_info. @data must have been allocated by kmalloc()
>> + * skb_shared_info. @data must have been allocated by kmalloc() only if
>> + * @frag_size is 0.
>>   * The return is the new skb buffer.
>>   * On a failure the return is %NULL, and @data is not freed.
>>   * Notes :
>
> Hmm, why not explaining the other case ? (frag_size > 0)

Sure, would something like:

"@data must have been allocated by kmalloc() if frag_size is 0,
otherwise any data buffer (vmalloc, DMA..) is suitable"

work for you?
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html