netdev - Re: r8169: remove "PHY reset until link up" log spam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130723141814.4d5ad51f@nehalam.linuxnetplumber.net>
Date:	Tue, 23 Jul 2013 14:18:14 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Peter Wu <lekensteyn@...il.com>,
	Francois Romieu <romieu@...zoreil.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	nic_swsd@...ltek.com
Subject: Re: r8169: remove "PHY reset until link up" log spam

This is what I was talking about, some patch like this.


--- a/drivers/net/ethernet/realtek/r8169.c	2013-07-19 09:12:37.121530393 -0700
+++ b/drivers/net/ethernet/realtek/r8169.c	2013-07-23 14:16:20.239516611 -0700
@@ -1496,11 +1496,12 @@ static void __rtl8169_check_link_status(
 		if (pm)
 			pm_request_resume(&tp->pci_dev->dev);
 		netif_carrier_on(dev);
-		if (net_ratelimit())
+		if (netif_msg_ifup(tp))
 			netif_info(tp, ifup, dev, "link up\n");
 	} else {
 		netif_carrier_off(dev);
-		netif_info(tp, ifdown, dev, "link down\n");
+		if (netif_msg_ifdown(tp))
+			netif_info(tp, ifdown, dev, "link down\n");
 		if (pm)
 			pm_schedule_suspend(&tp->pci_dev->dev, 5000);
 	}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html