netdev - Re: [PATCH v2 net-next 1/4] tcp: consolidate SYNACK RTT sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK6E8=eO7Ktx0J+4QChiy09dJyoWdrL6+g53_d8+i-QCM9PynA@mail.gmail.com>
Date:	Tue, 23 Jul 2013 08:54:35 -0700
From:	Yuchung Cheng <ycheng@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Neal Cardwell <ncardwell@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Nandita Dukkipati <nanditad@...gle.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 1/4] tcp: consolidate SYNACK RTT sampling

On Mon, Jul 22, 2013 at 6:02 PM, David Miller <davem@...emloft.net> wrote:
> From: Yuchung Cheng <ycheng@...gle.com>
> Date: Mon, 22 Jul 2013 16:20:45 -0700
>
>> This patch series improve RTT sampling in three ways:
>> 1. Sample RTT during fast recovery and reordering events.
>> 2. Favor ack-based RTT to timestamps because of broken TS ECR fields
>> 3. Consolidate the RTT measurement logic.
>>
>> The first patch consolidates SYNACK and other RTT measurement to use a
>> central function tcp_ack_update_rtt(). A (small) bonus is now SYNACK
>> RTT measurement happens after PAWS check, potentially reducing the
>> impact of RTO seeding on bad TCP timestamps values.
>>
>> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
>
> I like this series a lot, applied, thanks!
>
> Next time please submit a seperate "[PATCH 0/4] xxx" posting.
>
> If it has non-trivial content, I use the "0" posting as the
> commit message of a merge commit when I apply your series.
>
> What I did here was take the text:
>
> ====================
> This patch series improve RTT sampling in three ways:
> 1. Sample RTT during fast recovery and reordering events.
> 2. Favor ack-based RTT to timestamps because of broken TS ECR fields
> 3. Consolidate the RTT measurement logic.
> ====================
>
> and place it into that merge commit, removing it from the patch #1
> commit message.
Thank you David. Sorry for the extra hassle. Will definitely do that
for next patch series.

>
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html