netdev - Re: [PATCH net v2 1/1] r8169: fix lockdep warning when removing interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130724.154337.318987942705079482.davem@davemloft.net>
Date:	Wed, 24 Jul 2013 15:43:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lekensteyn@...il.com
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com, nic_swsd@...ltek.com
Subject: Re: [PATCH net v2 1/1] r8169: fix lockdep warning when removing
 interface

From: Peter Wu <lekensteyn@...il.com>
Date: Mon, 22 Jul 2013 09:53:30 +0200

> The work queue is initialised in rtl_open (when the interface goes up),
> but canceled in rtl_remove_one (when the PCI device gets removed). If
> the network interface is not brought up, then the work queue struct is
> not initialised. When the device is removed, the attempt to cancel the
> uninitialised work queue causes a lockdep warning.
> 
> This patch fixes the issue by moving cancel_work_sync to rtl_close (to
> match rtl_open). (Note that rtl_close is also called via
> unregister_netdev in rtl_remove_one.)
> 
> Signed-off-by: Peter Wu <lekensteyn@...il.com>
> Acked-by: Francois Romieu <romieu@...zoreil.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html