netdev - Re: [PATCH 1/4 v2] bonding: don't call slave_xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130724.174547.131365101717202321.davem@davemloft.net>
Date:	Wed, 24 Jul 2013 17:45:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, andy@...yhouse.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/4 v2] bonding: don't call slave_xxx_netpoll under
 spinlocks

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Tue, 23 Jul 2013 15:25:27 +0800

> The slave_xxx_netpoll will call synchronize_rcu_bh(),
> so the function may schedule and sleep, it should't be
> called under spinlocks.
> 
> bond_netpoll_setup() and bond_netpoll_cleanup() are always
> protected by rtnl lock, it is no need to take the read lock,
> as the slave list couldn't be changed outside rtnl lock.
> 
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html