netdev - Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1307250804180.1718@ja.ssi.bg>
Date:	Thu, 25 Jul 2013 08:08:11 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Joe Stringer <joe@...d.net.nz>
cc:	davem@...emloft.net, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, lvs-devel@...r.kernel.org,
	pablo@...filter.org, horms@...ge.net.au, jesse@...ira.com
Subject: Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum
 computation


	Hello,

On Thu, 25 Jul 2013, Joe Stringer wrote:

> This patch consolidates the SCTP checksum calculation code from various
> places to a single new function, sctp_compute_cksum(skb, offset).
> 
> Signed-off-by: Joe Stringer <joe@...d.net.nz>
> ---
> v2:
> * Use skb->data + offset for start position of checksum calculation
> * Fix existing bug in sctp_csum_check() where the incorrect offset was used
> * Remove redundant variable in sctp_nat_csum()

	v2 looks good to me, thanks!

Reviewed-by: Julian Anastasov <ja@....bg>

> ---
>  include/net/sctp/checksum.h           |   15 +++++++++++++++
>  net/netfilter/ipvs/ip_vs_proto_sctp.c |   23 +++--------------------
>  net/netfilter/nf_nat_proto_sctp.c     |    8 +-------
>  net/sctp/input.c                      |   10 +---------
>  4 files changed, 20 insertions(+), 36 deletions(-)

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html