netdev - Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130724.231522.347956000482833125.davem@davemloft.net>
Date:	Wed, 24 Jul 2013 23:15:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	ja@....bg, joe@...d.net.nz, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, lvs-devel@...r.kernel.org,
	pablo@...filter.org, jesse@...ira.com
Subject: Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum
 computation

From: Simon Horman <horms@...ge.net.au>
Date: Thu, 25 Jul 2013 14:24:38 +0900

> On Thu, Jul 25, 2013 at 08:08:11AM +0300, Julian Anastasov wrote:
>> 
>> 	Hello,
>> 
>> On Thu, 25 Jul 2013, Joe Stringer wrote:
>> 
>> > This patch consolidates the SCTP checksum calculation code from various
>> > places to a single new function, sctp_compute_cksum(skb, offset).
>> > 
>> > Signed-off-by: Joe Stringer <joe@...d.net.nz>
>> > ---
>> > v2:
>> > * Use skb->data + offset for start position of checksum calculation
>> > * Fix existing bug in sctp_csum_check() where the incorrect offset was used
>> > * Remove redundant variable in sctp_nat_csum()
>> 
>> 	v2 looks good to me, thanks!
>> 
>> Reviewed-by: Julian Anastasov <ja@....bg>
> 
> IPVS portion:
> 
> Acked-by: Simon Horman <horms@...ge.net.au>
> 
> Dave, could you consider taking this through net-next?

Sure.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html