lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 25 Jul 2013 10:57:38 +0200
From:	Andi Shyti <>
Subject: Re: [PATCH] 9p: client: remove unused code and any reference to
 "cancelled" function

Hi David,

On Thu, Jul 25, 2013 at 10:54:24AM +0200, Andi Shyti wrote:
> This patch reverts commit
> 80b45261a0b263536b043c5ccfc4ba4fc27c2acc
> which was implementing a 'cancelled' functionality to notify that
> a cancelled request will not be replied.
> This implementation was not used anywhere and therefore removed.

did you mean this?

> -	spin_lock(&c->lock);
>  	if (oldreq->status == REQ_STATUS_FLSH) {
> +		spin_lock(&c->lock);
>  		list_del(&oldreq->req_list);
>  		spin_unlock(&c->lock);
> -		if (c->trans_mod->cancelled)
> -			c->trans_mod->cancelled(c, req);

I just put the spin_lock inside the if statement, so that it
locks only if the statement it's true.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists