netdev - Re: [patch net-next v5 0/4] export device physical port id to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374843980.32309.9.camel@jtkirshe-mobl>
Date:	Fri, 26 Jul 2013 06:06:20 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	stephen@...workplumber.org, Narendra_K@...l.com,
	bhutchings@...arflare.com, john.r.fastabend@...el.com,
	or.gerlitz@...il.com, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, gregory.v.rose@...el.com,
	peter.p.waskiewicz.jr@...el.com, alexander.h.duyck@...el.com,
	john.ronciak@...el.com, tushar.n.dave@...el.com,
	matthew.vick@...el.com, mitch.a.williams@...el.com,
	vyasevic@...hat.com, amwang@...hat.com, johannes@...solutions.net
Subject: Re: [patch net-next v5 0/4] export device physical port id to
 userspace

On Fri, 2013-07-26 at 14:09 +0200, Jiri Pirko wrote:
> This patchset is based on patch by Narendra_K@...l.com
> Once device which can change phys port id during its lifetime adopts this,
> NETDEV_CHANGEPHYSPORTID event will be added and driver will call
> call_netdevice_notifiers(NETDEV_NETDEV_CHANGEPHYSPORTID, dev) to propagate
> the change to userspace.
> 
> v1->v2: as suggested by Ben, handle -EOPNOTSUPP in rtnl code (wrapped up ndo call)
> v2->v3: adjusted patch 1 commit message
> v3->v4: used "%phN" for sysfs printf as suggested by DaveM
>         added igb/igbvf implementation as requested by Or Gerlitz
> v4->v5: used prandom_u32 to generate id in igb_probe
> 	removed duplicate code in ibgvf_probe
> 	pushed dev_err string into one line in igbvf_refresh_ppid
> 
> Jiri Pirko (4):
>   net: add ndo to get id of physical port of the device
>   rtnl: export physical port id via RT netlink
>   net: export physical port id via sysfs
>   igb/igbvf: implement ndo_get_phys_port_id
> 

Jiri-
I do not want to hold up the entire series, especially since three of
the four patches are not against our drivers, but I would like to have
these changes tested in our validation labs.

I will apply the series internally for testing.  In the meantime, if I
get an ACK from Carolyn Wyborny and Greg Rose on the igb/igbvf patch, I
am good with Dave applying the series.

>  drivers/net/ethernet/intel/igb/e1000_mbx.h |  1 +
>  drivers/net/ethernet/intel/igb/igb.h       |  2 ++
>  drivers/net/ethernet/intel/igb/igb_main.c  | 29 +++++++++++++++++++++-
>  drivers/net/ethernet/intel/igbvf/igbvf.h   |  3 +++
>  drivers/net/ethernet/intel/igbvf/mbx.h     |  1 +
>  drivers/net/ethernet/intel/igbvf/netdev.c  | 40 ++++++++++++++++++++++++++++++
>  drivers/net/ethernet/intel/igbvf/vf.c      | 34 +++++++++++++++++++++++++
>  drivers/net/ethernet/intel/igbvf/vf.h      |  1 +
>  include/linux/netdevice.h                  | 20 +++++++++++++++
>  include/uapi/linux/if_link.h               |  1 +
>  net/core/dev.c                             | 18 ++++++++++++++
>  net/core/net-sysfs.c                       | 22 ++++++++++++++++
>  net/core/rtnetlink.c                       | 25 ++++++++++++++++++-
>  13 files changed, 195 insertions(+), 2 deletions(-)


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)