netdev - Re: [PATCH net-next v3] net: split rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130726144316.GB3890@order.stressinduktion.org>
Date:	Fri, 26 Jul 2013 16:43:16 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Fan Du <fan.du@...driver.com>
Cc:	nicolas.dichtel@...nd.com, davem@...emloft.net,
	yoshfuji@...ux-ipv6.org, jmorris@...ei.org,
	steffen.klassert@...unet.com, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] net: split rt_genid for ipv4 and ipv6

On Fri, Jul 26, 2013 at 01:49:35PM +0800, Fan Du wrote:
> diff --git a/security/selinux/include/xfrm.h 
> b/security/selinux/include/xfrm.h
> index 65f67cb..4f72d2c 100644
> --- a/security/selinux/include/xfrm.h
> +++ b/security/selinux/include/xfrm.h
> @@ -50,8 +50,14 @@ int selinux_xfrm_decode_session(struct sk_buff *skb, u32 
> *sid, int ckall);
> 
>  static inline void selinux_xfrm_notify_policyload(void)
>  {
> +       struct net *net;
> +
>         atomic_inc(&flow_cache_genid);
> -       rt_genid_bump(&init_net);
> +       rtnl_lock();
> +       for_each_net(net) {
> +               rt_genid_bump_all(net);
> +       }
> +       rtnl_unlock();
>  }
>  #else
>  static inline int selinux_xfrm_enabled(void)
> 
> 
> Let me know if I miss something inside it. Thanks.

I do think it is the correct change. The locking seems correct, too. I will
excercise the code with lockdep as soon as you publish a new patch.

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html