netdev - Re: [PATCH net-next 1/2] gianfar: Fix data structure field comments in gianfar.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130726.152257.1002325488353326528.davem@davemloft.net>
Date:	Fri, 26 Jul 2013 15:22:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	claudiu.manoil@...escale.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] gianfar: Fix data structure field
 comments in gianfar.h

From: Claudiu Manoil <claudiu.manoil@...escale.com>
Date: Wed, 24 Jul 2013 17:43:34 +0300

> Improve clarity of struct member comments for tx_q and and rx_q
> (see cur_tx, dirty_tx, skb_curtx). Fix misleading comments (see
> skb_currx, cur_rx) and remove outdated ones (txcount, txtime).
> Make comments readable (and maintainable) by placing them above
> the individual targeted members.
> Fix checkpatch warnings (see __aligned()) and spacing issues
> in the process.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com>

Please don't undo the usage of kerneldoc comments to describe
structure members.

I'm not applying this patch series, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html