netdev - Re: [net PATCH] atl1c: Fix misuse of netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87hafgrmvm.fsf@canonical.com>
Date:	Sat, 27 Jul 2013 17:25:17 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	David Miller <davem@...emloft.net>
Cc:	nhorman@...driver.com, netdev@...r.kernel.org, jcliburn@...il.com,
	stable@...r.kernel.org
Subject: Re: [net PATCH] atl1c: Fix misuse of netdev_alloc_skb in refilling rx ring

David Miller <davem@...emloft.net> writes:

> From: Neil Horman <nhorman@...driver.com>
> Date: Fri, 26 Jul 2013 13:02:51 -0400
>
>> On Fri, Jul 26, 2013 at 05:56:16PM +0100, Luis Henriques wrote:
>>> Neil Horman <nhorman@...driver.com> writes:
>>> 
>>> > atl1c uses netdev_alloc_skb to refill its rx dma ring, but that call makes no
>>> > guarantees about the suitability of the memory for use in DMA.  As a result
>>> > we've gotten reports of atl1c drivers occasionally hanging and needing to be
>>> > reset:
>>> > https://bugzilla.kernel.org/show_bug.cgi?id=54021
>>> >
>>> > Fix this by modifying the call to use the internal version __netdev_alloc_skb,
>>> > where you can set the gfp_mask explicitly to include GFP_DMA.
>>> >
>>> > Tested by two reporters in the above bug, who have the hardware to validate it.
>>> > Both report immediate cessation of the problem with this patch
>>> >
>>> > Signed-off-by: Neil Horman <nhorman@...driver.com>
>>> > CC: Jay Cliburn <jcliburn@...il.com>
>>> > CC: "David S. Miller" <davem@...emloft.net>
>>> > CC: stable@...r.kernel.org
>>> > Tested-by: Luis Henrix <luis.henrix@...il.com>
>>> 
>>> Thanks Neil!
>>> 
>>> Would it be possible for you to update my name and email?  (I've just
>>> updated my bz account to remove my gmail account address -- I thought
>>> I had done this ages ago.)
>>> 
>>> Tested-by: Luis Henriques <luis.henriques@...onical.com>
>>> 
>> I'm sure if Dave has time, he will square that up.
>
> I took care of this while applying Neil's patch, thanks.

Thanks!

Cheers,
-- 
Luis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html