netdev - Re: [PATCH net-next] bonding: remove bond_resend_igmp_join_requests read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130727200754.GA2395@minipsycho.orion>
Date:	Sat, 27 Jul 2013 22:07:54 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	netdev@...r.kernel.org, andy@...yhouse.net, fubar@...ibm.com,
	davem@...emloft.net
Subject: Re: [PATCH net-next] bonding: remove bond_resend_igmp_join_requests
 read_unlock leftover

Sat, Jul 27, 2013 at 07:10:10PM CEST, nikolay@...hat.com wrote:
>After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event") we
>have 1 read_unlock in bond_resend_igmp_join_requests which isn't paired
>with a read_lock because it's removed by that commit.

Oups

>
>Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>
Reviewed-by: Jiri Pirko <jiri@...nulli.us>


>---
> drivers/net/bonding/bond_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index f584352..da3af63 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -739,7 +739,6 @@ static void bond_resend_igmp_join_requests(struct bonding *bond)
> 		queue_delayed_work(bond->wq, &bond->mcast_work, HZ/5);
> 	}
> 	write_unlock_bh(&bond->curr_slave_lock);
>-	read_unlock(&bond->lock);
> }
> 
> static void bond_resend_igmp_join_requests_delayed(struct work_struct *work)
>-- 
>1.8.1.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html