netdev - Re: [net 2/2] igb: fix vlan filtering in promisc mode when not in VT mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130728.131750.1700424516115373731.davem@davemloft.net>
Date:	Sun, 28 Jul 2013 13:17:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	emil.s.tantilov@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net 2/2] igb: fix vlan filtering in promisc mode when not in
 VT mode

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 26 Jul 2013 05:46:36 -0700

> From: Emil Tantilov <emil.s.tantilov@...el.com>
> 
> This patch fixes a VT mode check to make sure VLAN filters are disabled when
> in promisc mode and VT is not enabled.
> 
> The problem with the previous check was that:
> E1000_MRQC_ENABLE_VMDQ is defined as 0x00000003
> 
> but when not in VT mode:
> mrqc |= E1000_MRQC_ENABLE_RSS_4Q (0x00000002)
> 
> So the above check will trigger regardless if VT mode is being used or not.
> 
> Signed-off-by: Emil Tantilov <emil.s.tantilov@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html