netdev - Re: [net-next 08/15] pci: expose pcie_link_speed and pcix_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375131833.5297.14.camel@jekeller-desk1.amr.corp.intel.com>
Date:	Mon, 29 Jul 2013 21:03:53 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [net-next 08/15] pci: expose pcie_link_speed and pcix_bus_speed
 arrays

On Mon, 2013-07-29 at 12:44 -0600, Bjorn Helgaas wrote:
> On Mon, Jul 29, 2013 at 6:52 AM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > From: Jacob Keller <jacob.e.keller@...el.com>
> >
> > pcie_link_speed and pcix_bus_speed are arrays used by probe.c to correctly
> > convert lnksta register values into the pci_bus_speed enum. These static arrays
> > are useful outside probe for this purpose. This patch makes these defines into
> > const arrays and exposes them with an extern header in linux/include/pci.h
> >
> > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> > Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > ---
> >  drivers/pci/probe.c | 4 ++--
> >  include/linux/pci.h | 3 +++
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> > index 46ada5c..496c5b0 100644
> > --- a/drivers/pci/probe.c
> > +++ b/drivers/pci/probe.c
> > @@ -513,7 +513,7 @@ static struct pci_host_bridge *pci_alloc_host_bridge(struct pci_bus *b)
> >         return bridge;
> >  }
> >
> > -static unsigned char pcix_bus_speed[] = {
> > +const unsigned char pcix_bus_speed[] = {
> >         PCI_SPEED_UNKNOWN,              /* 0 */
> >         PCI_SPEED_66MHz_PCIX,           /* 1 */
> >         PCI_SPEED_100MHz_PCIX,          /* 2 */
> > @@ -532,7 +532,7 @@ static unsigned char pcix_bus_speed[] = {
> >         PCI_SPEED_133MHz_PCIX_533       /* F */
> >  };
> >
> > -static unsigned char pcie_link_speed[] = {
> > +const unsigned char pcie_link_speed[] = {
> >         PCI_SPEED_UNKNOWN,              /* 0 */
> >         PCIE_SPEED_2_5GT,               /* 1 */
> >         PCIE_SPEED_5_0GT,               /* 2 */
> > diff --git a/include/linux/pci.h b/include/linux/pci.h
> > index 0fd1f15..95ff993 100644
> > --- a/include/linux/pci.h
> > +++ b/include/linux/pci.h
> > @@ -120,6 +120,9 @@ typedef int __bitwise pci_power_t;
> >  /* Remember to update this when the list above changes! */
> >  extern const char *pci_power_names[];
> >
> > +extern const unsigned char pcix_bus_speed[];
> > +extern const unsigned char pcie_link_speed[];
> 
> As far as I can tell, you didn't actually add anything that uses
> pcix_bus_speed[].
> 

I mostly added this for consistency...

> You added a pcie_link_speed[] use only in drivers/pci/pci.c; maybe
> this extern declaration could go in drivers/pci/pci.h to limit its
> visibility?

Pretty sure I use the pcie_link_speed in the ixgbe driver by including
the linux/pci.h header...  Check patch 11/15 of this series where I
actually use the values, so it would need to be in the linux/pci.h
header.

> 
> If you update this patch, note that we conventionally capitalize "PCI:
> Expose ..." in the changelog summary, e.g., "git log --oneline
> drivers/pci".

Oh. good to know, I will keep that in mind for future.
> 
> >  static inline const char *pci_power_name(pci_power_t state)
> >  {
> >         return pci_power_names[1 + (int) state];
> > --
> > 1.7.11.7
> >

Thanks,
Jake